Skip to content

[WIP][DIFF] ✨ Update to code-generator/v3 #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: kcp-1.32.3
Choose a base branch
from
Open

[WIP][DIFF] ✨ Update to code-generator/v3 #46

wants to merge 5 commits into from

Conversation

ntnn
Copy link
Member

@ntnn ntnn commented Jun 17, 2025

Diff only version without codegen of #45

@kcp-ci-bot kcp-ci-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has signed the DCO. labels Jun 17, 2025
@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mjudeikis for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 17, 2025
@ntnn ntnn force-pushed the update-code-gen-diff branch from 74f18b8 to d6d7e3d Compare June 17, 2025 11:52
@ntnn ntnn mentioned this pull request Jun 17, 2025
Open
ntnn
ntnn commented Jun 17, 2025
View reviewed changes
dynamic/dynamicinformer/informer.go
return d.ClusterWithContext(context.Background(), clusterName)
}

func (d *dynamicClusterInformer) ClusterWithContext(ctx context.Context, clusterName logicalcluster.Name) upstreaminformers.GenericInformer {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ClusterWithContext is already part of code-generator/v3 so the interfaces must be satisfied.

@ntnn ntnn force-pushed the update-code-gen-diff branch 3 times, most recently from 46f1b59 to d917098 Compare June 17, 2025 23:00
@ntnn ntnn force-pushed the update-code-gen-diff branch from d917098 to 6d6db25 Compare June 17, 2025 23:25
@ntnn
Update kcp-dev/apimachinery
1d97895 
Signed-off-by: Nelo-T. Wallus <[email protected]>
@kcp-ci-bot
Copy link
Contributor

@ntnn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-client-go-verify 1d97895 link true /test pull-client-go-verify
pull-client-go-lint 1d97895 link true /test pull-client-go-lint

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dco-signoff: yes Indicates the PR's author has signed the DCO. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ntnn @kcp-ci-bot