Skip to content

Conversation

@dereknola
Copy link
Member

@dereknola dereknola commented Dec 2, 2025

Proposed Changes

Makes translating between docker and E2E tests more seemless.

  • Moved RunCommand into central testing utility package
  • Exported docker test Kubeconfig for similar usage by RunCommand that E2E already had
  • Consolidated docker testing import to docker across all docker tests
  • Move away from legacy ranchertest/mycontainer to a modern nginx/busybox image

Types of Changes

Verification

CI still green

Testing

Its all testing

Linked Issues

User-Facing Change


Further Comments

@dereknola dereknola requested a review from a team as a code owner December 2, 2025 19:29
@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 21.74%. Comparing base (68749aa) to head (420227a).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13281      +/-   ##
==========================================
- Coverage   21.75%   21.74%   -0.01%     
==========================================
  Files         186      186              
  Lines       15284    15284              
==========================================
- Hits         3325     3324       -1     
- Misses      11520    11521       +1     
  Partials      439      439              
Flag Coverage Δ
unittests 21.74% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dereknola dereknola force-pushed the consolidate_test_utils branch 3 times, most recently from a0a5ee6 to d5d4e63 Compare December 5, 2025 18:43
@dereknola dereknola force-pushed the consolidate_test_utils branch from d5d4e63 to 5553223 Compare December 5, 2025 19:04
@dereknola dereknola force-pushed the consolidate_test_utils branch from 5553223 to 420227a Compare December 5, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants