Bump spegel to upstream v0.5.1 #13198
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13198 +/- ##
==========================================
- Coverage 21.75% 21.66% -0.10%
==========================================
Files 186 187 +1
Lines 15284 15349 +65
==========================================
Hits 3325 3325
- Misses 11520 11585 +65
Partials 439 439
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
brandond
force-pushed
the
bump-spegel
branch
2 times, most recently
from
77be282 to
d4a3aae
Compare
Member
Author
|
Should probably wait on spegel-org/spegel#1091 to be fixed first |
dereknola
previously approved these changes
Nov 17, 2025
Signed-off-by: Brad Davidson <[email protected]>
Spegel insists on checking containerd features when the store is created, so defer creating it until after contaienerd is up Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Brad Davidson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
oci.NewContainerd()now validates containerd features earlier, so we can no longer create the store and just wait to start the Tracker until containerd is up.Types of Changes
version bump; removal of maintained fork
Verification
Check spegel version in go.mod
Testing
Yes
Linked Issues
User-Facing Change
Further Comments