Skip to content

fix: navbar going opaque off white on scrolling up on some machines #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: navbar going opaque off white on scrolling up on some machines #53

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70bb3dd
fix: navbar going opaque off white on scrolling up on some machines
Akeboshiwind Nov 1, 2023
9192c96
fix: change to using padding instead of margin
Akeboshiwind Nov 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/components/Navbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,14 @@ export default function Navbar({ navLinks, enableDarkMode, navbarNoBg }) {
'bg-black': !navbarNoBg
})}
ref={ref}
/* Fix for a bug that only @joa was able to reproduce.
* For reference:
* - MacOS
* - Chrome: Version 118.0.5993.117 (Official Build) (arm64)
* - No specific window size
* On scrolling down and then back up the navbar would go an opaque off white.
*/
style="padding-top: 1px;"
>
<div className='container mx-auto px-4 sm:px-12 2xl:px-0 max-w-7xl flex flex-wrap items-center justify-between h-full'>
<a href='/' class='flex items-center w-20 z-10'>
Expand Down