Skip to content
This repository was archived by the owner on Feb 16, 2023. It is now read-only.

Update to JupyterLab 3.3.0 #351

Merged
merged 16 commits into from
Mar 3, 2022
Merged

Update to JupyterLab 3.3.0 #351

merged 16 commits into from
Mar 3, 2022

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Feb 18, 2022

Update to the JupyterLab 3.3.0rc0 packages, to help catch potential issues if any.

@jtpio jtpio added this to the 0.3.x milestone Feb 18, 2022
@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch jtpio/retrolab/lab-3-3

@jtpio jtpio added the enhancement New feature or request label Feb 18, 2022
@jtpio
Copy link
Member Author

jtpio commented Feb 18, 2022

Looks like the notebook:create-new command is not registered by default anymore:

image

@jtpio
Copy link
Member Author

jtpio commented Feb 18, 2022

Some toolbar positioning to fix:

image

// TODO: get factory from file type instead?
if (ext === '.ipynb') {
await settingRegistry?.load('@jupyterlab/notebook-extension:panel');
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same trick was added on the main branch (targeting lab 4.0) in #319.

However for RetroLab 0.3.x we should find a better way to handle this.

@jtpio
Copy link
Member Author

jtpio commented Feb 23, 2022

Without the workaround (commit 978fef7)

Binder: https://mybinder.org/v2/gh/jtpio/retrolab/978fef7?urlpath=retro

image

With the workaround (commit dd750da)

Binder: https://mybinder.org/v2/gh/jtpio/retrolab/dd750da?urlpath=retro

image

As the next step I will be looking into dropping the workaround, and use a similar approach as in JupyterLab to register toolbar widgets:

https://github.com/jupyterlab/jupyterlab/blob/b27408b1bf70bad1cb519fc8993d0dc03f56362e/packages/notebook-extension/src/index.ts#L926-L939

@jtpio
Copy link
Member Author

jtpio commented Feb 23, 2022

Looking better now.

Next steps:

@jtpio jtpio changed the title Update to JupyterLab 3.3.0rc0 Update to JupyterLab 3.3.0 Mar 3, 2022
@jtpio jtpio marked this pull request as ready for review March 3, 2022 08:28
@jtpio
Copy link
Member Author

jtpio commented Mar 3, 2022

Now updated to the 3.3.0 final packages.

@jtpio jtpio merged commit c15e26b into jupyterlab:0.3.x Mar 3, 2022
@jtpio jtpio deleted the lab-3-3 branch March 3, 2022 09:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant