This repository was archived by the owner on Feb 16, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 46
Strip .ipynb extension for display in header and tab title #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "enforce-label" job failed, but the |
Can someone please assign this issue to me? |
Thanks @jweill-aws! Mind posting a small before / after screenshot in the top comment for reference? |
We could also apply the same logic to the browser tab title: Which is updated in this plugin: retrolab/packages/application-extension/src/index.ts Lines 371 to 404 in 4fd58de
|
jtpio
approved these changes
Dec 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #160 by stripping only
.ipynb
from the end of filenames displayed in the workbook title.Before the change, "Untitled.ipynb" appears to the right of the Jupyter logo in the top area and in the tab title.

After the change, "Untitled" appears in these areas.
