Skip to content

Move YDocWebSocketHandler to jupyter-server #12772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2022
Merged

Move YDocWebSocketHandler to jupyter-server #12772

merged 1 commit into from
Jul 25, 2022

Conversation

davidbrochart
Copy link
Contributor

@davidbrochart davidbrochart commented Jul 5, 2022 •
edited
Loading

References

Closes #12770.

Code changes

The YDocWebSocketHandler moved to jupyter_server_ydoc.

User-facing changes

None.

Backwards-incompatible changes

None.

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

jtpio
jtpio reviewed Jul 5, 2022
View reviewed changes
@jtpio jtpio added this to the 4.0.0 milestone Jul 5, 2022
@davidbrochart davidbrochart force-pushed the rm_YDocWebSocketHandler branch from d60f2e0 to 155afc6 Compare July 10, 2022 20:23
@davidbrochart davidbrochart marked this pull request as draft July 10, 2022 20:24
@davidbrochart
Copy link
Contributor Author

Tests are failing because jupyter_server_ydoc has not been released yet.

@davidbrochart davidbrochart marked this pull request as ready for review July 11, 2022 05:00
@davidbrochart
Copy link
Contributor Author

I think the CI failures are not related.

@davidbrochart davidbrochart mentioned this pull request Jul 11, 2022
Merged
@davidbrochart davidbrochart force-pushed the rm_YDocWebSocketHandler branch from a25480c to 6b5ca4e Compare July 11, 2022 14:44
@davidbrochart
Copy link
Contributor Author

The YDocWebSocketHandler moved to jupyter_server_ydoc.
This is ready to be merged.

@davidbrochart
Copy link
Contributor Author

OK to merge?

jtpio
jtpio approved these changes Jul 25, 2022
View reviewed changes
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio
Copy link
Member

jtpio commented Jul 25, 2022

The release_test failure was fixed in #12799

@jtpio jtpio merged commit 89c720b into jupyterlab:master Jul 25, 2022
@davidbrochart davidbrochart deleted the rm_YDocWebSocketHandler branch July 25, 2022 12:27
@davidbrochart davidbrochart mentioned this pull request Sep 26, 2022
Closed
@davidbrochart davidbrochart mentioned this pull request Oct 11, 2022
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jtpio jtpio jtpio approved these changes

Assignees

@davidbrochart davidbrochart

Labels
maintenance
Projects
No open projects
Real Time Collaboration
Status: Done
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

Move YDocWebSocketHandler to Jupyter Server core
3 participants
@davidbrochart @jtpio @trungleduc