Skip to content

Fix case-sensitivity in user mention commands #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2025

Conversation

brichet
Copy link
Collaborator

@brichet brichet commented Apr 16, 2025

Fixes #209 by comparing only lower case string.

Copy link
Contributor

Binder 👈 Launch a Binder on branch brichet/jupyter-chat/fix_user_mention

@brichet brichet added the bug Something isn't working label Apr 16, 2025
@brichet brichet changed the title User mention commands not case sensitive Fix case-sensitivity in user mention commands Apr 16, 2025
Copy link
Member

@dlqqq dlqqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ 🎉 Thank you! Excited to update the personas PR to pull in this change.

@brichet brichet merged commit 171ebfa into jupyterlab:main Apr 17, 2025
14 of 15 checks passed
@brichet brichet deleted the fix_user_mention branch April 17, 2025 05:38
@brichet
Copy link
Collaborator Author

brichet commented Apr 17, 2025

Released in v0.10.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@-mention command is case-sensitive
2 participants