Skip to content

JupyterLab 3.0: bump image prefix across the federation #2009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 10, 2021

Conversation

minrk
Copy link
Member

@minrk minrk commented Sep 6, 2021

The order these things should be done in (they can be simultaneous, but some should not be before others):

  1. update jupyterlab default UI in repo2docker (merged Default UI to JupyterLab repo2docker#1035)
  2. invalidate image cache by bumping image prefix (this pr). Cache should be invalidated with/after the r2d bump so we can assume new builds have lab 3.1.
  3. bump binderhub filepath handling to use jupyterlab Send filepath urls to JupyterLab instead of classic notebook binderhub#1288 . This change is where we start to apply the assumption that cached builds have jupyterlab 3, and provide consistent UI for both filepath and default URLs.

This PR currently does all 3 (includes #2011 and #2014)

Purging the image cache means lots of new builds, and we will probably want to sweep out our old cache (related: #2012)

@minrk minrk force-pushed the bump-image-prefix branch 2 times, most recently from 581eb88 to 3d41c50 Compare September 6, 2021 12:19
effectively purges image cache, ensuring all builds are getting jlab 3.1
Copy link
Member

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this Min! This LGTM!

As discussed in a video chat:

  • Min plan to deploy this to staging and try it out there.
  • We want to clean up images. Currently, we do that manually with a search of images to be cleaned based on their name that doesn't match the new prefix. This is not essential to do directly or similar, but an action point of relevance to get done.

Loose thoughts:

  • Use launch data...
  • Limiting the number of builds per repo (each has a specific SHA)
  • It could be nice to see the available SHA for a repo

@minrk
Copy link
Member Author

minrk commented Sep 9, 2021

/test-this-pr

1 similar comment
@minrk
Copy link
Member Author

minrk commented Sep 9, 2021

/test-this-pr

@sgibson91
Copy link
Member

This Pull Request is now being tested 🎉 See the test progress in GitHub Actions.

@minrk
Copy link
Member Author

minrk commented Sep 9, 2021

/test-this-pr

@sgibson91
Copy link
Member

This Pull Request is now being tested 🎉 See the test progress in GitHub Actions.

@sgibson91
Copy link
Member

Sidebar: We might need give the GITHUB_TOKEN extra permissions or use my token in the report_status job to avoid these errors

Error: Unhandled error: HttpError: Resource not accessible by integration

@minrk
Copy link
Member Author

minrk commented Sep 9, 2021

@sgibson91 yes! I was just writing a note about that. Deploy worked great, up to the delete & post-after-done steps, which need permissions.

@minrk minrk force-pushed the bump-image-prefix branch from 60848d8 to 60dc16c Compare September 9, 2021 13:53
@minrk
Copy link
Member Author

minrk commented Sep 9, 2021

/test-this-pr

@sgibson91
Copy link
Member

This Pull Request is now being tested 🎉 See the test progress in GitHub Actions.

@minrk minrk force-pushed the bump-image-prefix branch from 60dc16c to 409188d Compare September 9, 2021 14:08
@minrk
Copy link
Member Author

minrk commented Sep 9, 2021

/test-this-pr

@sgibson91
Copy link
Member

This Pull Request is now being tested 🎉 See the test progress in GitHub Actions.

@minrk
Copy link
Member Author

minrk commented Sep 9, 2021

okay, finally got it. Links to test on staging, all do what they are supposed to:

@minrk
Copy link
Member Author

minrk commented Sep 9, 2021

Since this is disruptive and my day is ending, I'll deploy this to prod, tomorrow AM

@minrk minrk merged commit 62bee99 into jupyterhub:master Sep 10, 2021
@minrk minrk deleted the bump-image-prefix branch September 10, 2021 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants