-
Notifications
You must be signed in to change notification settings - Fork 75
JupyterLab 3.0: bump image prefix across the federation #2009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
581eb88
to
3d41c50
Compare
effectively purges image cache, ensuring all builds are getting jlab 3.1
3d41c50
to
76d9820
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work on this Min! This LGTM!
As discussed in a video chat:
- Min plan to deploy this to staging and try it out there.
- We want to clean up images. Currently, we do that manually with a search of images to be cleaned based on their name that doesn't match the new prefix. This is not essential to do directly or similar, but an action point of relevance to get done.
Loose thoughts:
- Use launch data...
- Limiting the number of builds per repo (each has a specific SHA)
- It could be nice to see the available SHA for a repo
/test-this-pr |
1 similar comment
/test-this-pr |
This Pull Request is now being tested 🎉 See the test progress in GitHub Actions. |
/test-this-pr |
This Pull Request is now being tested 🎉 See the test progress in GitHub Actions. |
Sidebar: We might need give the
|
@sgibson91 yes! I was just writing a note about that. Deploy worked great, up to the delete & post-after-done steps, which need permissions. |
60848d8
to
60dc16c
Compare
/test-this-pr |
This Pull Request is now being tested 🎉 See the test progress in GitHub Actions. |
60dc16c
to
409188d
Compare
/test-this-pr |
This Pull Request is now being tested 🎉 See the test progress in GitHub Actions. |
okay, finally got it. Links to test on staging, all do what they are supposed to:
|
Since this is disruptive and my day is ending, I'll deploy this to prod, tomorrow AM |
The order these things should be done in (they can be simultaneous, but some should not be before others):
This PR currently does all 3 (includes #2011 and #2014)
Purging the image cache means lots of new builds, and we will probably want to sweep out our old cache (related: #2012)