-
Notifications
You must be signed in to change notification settings - Fork 397
Add configuration for optional CPU request on build pod #1984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Unfortunately this won't work, because the "build pod" doesn't build the image directly, it calls out to an external Docker or Podman build daemon. |
@manics |
Bump |
@bluek1te some tests are failing and I think we might have fixed it already. Can you rebase this pull request so that we can check the tests? Thanks! |
@rgaiacs looks like the tests failed after syncing, but they are timeout errors and I don't think they are related to my changes. Is there an easy way to rerun these tests on my side without pushing empty commits? |
I recently discovered that close and open the pull request will trigger a new CI job. There is also an option when you look at the logs of the job but I don't know what access level is required to trigger the re-run. I'm manually trigger a re-run of the failed jobs. |
During the first CI run, tests (v1.30, main) and tests (v1.29, helm, pink failed. During the second CI run, only tests (v1.30, main) failed. The reason for the tests to fail are different. The first time was
the second time was
I don't think this pull request is related with the above test failure given that only the test for figshare failed. |
I've rerun the tests and they look like they are all passing now. |
Add ability to configure CPU request on build pod - We have cluster restrictions that require us to affix a cpu request before spawning pods so this would help us immensely.