Test dind and pink #1602
Merged
Test dind and pink #1602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow it seems like a lot of effort went into this given the complexity of it. Thank you for your work @manics!!!! |
|
Thanks for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently test 3 Helm chart configurations. This means we can test all three
imageBuilderTypewithout increasing the number of matrix items.Currently we only test
host, but since docker is no longer part of Kubernetes most production deployments will usedind(or similar) so I think we should test it as standard even though it means deploying a registry.When building images with chartpress we can use
localhostsince it's running outside K8s, but we need to use the hosts's external IP ($REGISTRY_HOST) when referring to images from inside K8s.(extracted from #1521)