fix: update a reference to a k8s Secret that changed name #1294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
May 11, 2021
jupyterhub/binderhub#1294 Merge pull request #1294 from consideRatio/pr/fix-1293
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complements #1255 by updating all references to a renamed k8s Secret resource, and closes #1293.
The reason the CI passed was probably that we didn't have
use_registryconfigured in our CI system, and then this reference could have been outdated and it wouldn't have mattered.