Skip to content

Label is missing for form textarea element on notebook page: issue #3939 #4735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 12, 2019
Merged

Label is missing for form textarea element on notebook page: issue #3939 #4735

merged 3 commits into from
Jul 12, 2019

Conversation

fabihaahmed
Copy link
Contributor

I have fixed the issue #3939 by using the aria-label attribute. So now the type of the textarea on notebook page is announced by narrator.

@takluyver
Copy link
Member

Can you add localisation, like in #4744?

@fabihaahmed
Copy link
Contributor Author

Hi, I have made the necessary changes.

@takluyver takluyver added this to the 6.0 milestone Jul 12, 2019
@takluyver takluyver merged commit c8de32f into jupyter:master Jul 12, 2019
@takluyver
Copy link
Member

Thanks

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
status:resolved-locked tag:Accessibility
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@fabihaahmed @takluyver