-
Notifications
You must be signed in to change notification settings - Fork 3k
Update 2020-12-27 #1206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Update 2020-12-27 #1206
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e81957f
Regular update: 2020-12-27
romainx c41616d
#1205: Fix the configuration in jupyter_server_config.py
romainx 9648e05
#1205: Fix c.ServerApp.certfile
romainx 96deb9f
#1205: Manage both config files
romainx 6ae8512
Rollback to JupyterLab 2.2x
romainx 35d3fff
Basic check of extension added
romainx 6282153
Accept review suggestion with a best comment
romainx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
# Copyright (c) Jupyter Development Team. | ||
# Distributed under the terms of the Modified BSD License. | ||
import logging | ||
|
||
import pytest | ||
|
||
LOGGER = logging.getLogger(__name__) | ||
|
||
|
||
@pytest.mark.parametrize( | ||
"extension", | ||
[ | ||
"@bokeh/jupyter_bokeh", | ||
"@jupyter-widgets/jupyterlab-manager", | ||
"jupyter-matplotlib", | ||
], | ||
) | ||
def test_check_extension(container, extension): | ||
"""Basic check of each extension""" | ||
LOGGER.info(f"Checking the extension: {extension} ...") | ||
c = container.run( | ||
tty=True, command=["start.sh", "jupyter", "labextension", "check", extension] | ||
) | ||
rv = c.wait(timeout=10) | ||
logs = c.logs(stdout=True).decode("utf-8") | ||
LOGGER.debug(logs) | ||
assert rv == 0 or rv["StatusCode"] == 0, f"Extension {extension} check failed" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,6 +7,6 @@ LABEL maintainer="Jupyter Project <[email protected]>" | |
|
||
# Install Tensorflow | ||
RUN pip install --quiet --no-cache-dir \ | ||
'tensorflow==2.3.1' && \ | ||
'tensorflow==2.4.0' && \ | ||
fix-permissions "${CONDA_DIR}" && \ | ||
fix-permissions "/home/${NB_USER}" |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.