Remove @material-ui/* dependencies and move relevant packages to peerDependencies. #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! Thank you for this great component. It's really helped us and we're grateful for the time spent on it by you folks.
This pull request attempts to resolve the following warning in @material-ui when several instances of its packages exist in a single bundle:
With
yarn listwe can see that the host project and this component library both have a dependency on@material-ui/styles:Can we expect users of this package to already be using @materia-ui and therefore have those packages as peerDependencies? :)
Thanks for considering this change and again for creating this great component.