Search by title input #41
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliangruber
requested changes
Jan 30, 2023
| default: 'desc' | ||
| required: false | ||
| title: | ||
| description: 'Title of the Pull Request to search for.' |
There was a problem hiding this comment.
Suggested change
| description: 'Title of the Pull Request to search for.' | |
| description: 'The title of the Pull Request' |
| res.data.filter( | ||
| pr => | ||
| (!author || pr.user.login === author) && | ||
| (!title || pr.title.match(new RegExp(title))) |
There was a problem hiding this comment.
do you need this to be a regular expression? could it be a substring? or do you want to match on the exact title?
There was a problem hiding this comment.
Regex covers more use cases; pattern matching, partial matching or exact matches should be supported (I haven't tried this). Plain strings can still be used, with the cavat that special characters will have to be escaped. (This is how I'm using it).
There was a problem hiding this comment.
Gotcha, shall we simplify this PR then by only supporting exact matches for now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds input option to search for PR based on title.