-
Notifications
You must be signed in to change notification settings - Fork 0
WIP: Add support for rust-lightning-bitcoinrpc #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f899383 to
601f987
Compare
|
Hey, I'm almost successful running the test framework. I've dig a little into it, it's using per-implementation fixture to run the test and wait some kind of IPC to talk between fixture and implementation, We are not necessary constrained to use RPC, but I think a foreground process like rust-lightning-bitcoinrpc driven by shell input isn't going to fit. What's yours thoughts on it ? |
|
We may rework rust-lightning-bitcoinrpc in a more daemonic way or go forward on rust-lnd, but I would like to avoid one big daemon and I'm excited by having something like a routerd, a p2pd, a managed, a monitord, and use bitcoind and bitcoin-wallet as backend. More on it tomorrow :) |
|
Well, my plan was to mimic clightning's rpc to pass the tests, but just
accessing with http (curl or whatever) instead of having an
rust-lightning-cli or whatever.
I'm open to other options, but I thought this was the simplest way to pass
the tests. I don't doubt other architectures could be better for
production, but I working under the assumption that this was just a minimal
daemon to pasd the tests while maintaining the panic to avoid using it in
production and stuff.
You say you almost got it to pass the tests, can I see your branch?
My plan was to start working on the python wrapper for it to pass the tests
next week.
|
7b021c5 to
97d42d9
Compare
d6ec9c0 to
73fb2b6
Compare
816db4e to
5420ed7
Compare
5420ed7 to
0f65214
Compare
c29f5c3 to
aabb2b3
Compare
aabb2b3 to
5f03655
Compare
e9cebd8 to
3097dd6
Compare
… that can be run plus use makefile from travis for install
3097dd6 to
e546176
Compare
f6d386e to
58c6e06
Compare
|
Closing in favor of cdecker#81 |
Even though https://github.com/TheBlueMatt/rust-lightning-bitcoinrpc should not be used in production, it can be used as a tool so that we can test rust-lightning here.
This is not close to be ready.