Skip to content

add compatibility to Oj gem for faster JSON generation #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

add compatibility to Oj gem for faster JSON generation #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions lib/jsonapi/renderer/cached_resources_processor.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@ class Renderer
# @private
class CachedResourcesProcessor < ResourcesProcessor
class JSONString < String
def to_json(*)
self
end
end

def initialize(cache)
Expand All @@ -19,9 +16,7 @@ def process_resources
cache_hash = cache_key_map(resources)
processed_resources = @cache.fetch_multi(*cache_hash.keys) do |key|
res, include, fields = cache_hash[key]
json = res.as_jsonapi(include: include, fields: fields).to_json

JSONString.new(json)
res.as_jsonapi(include: include, fields: fields)
end

resources.replace(processed_resources.values)
Expand Down
2 changes: 1 addition & 1 deletion spec/caching_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,6 @@ def fetch_multi(*keys)
}

expect(JSON.parse(actual.to_json)).to eq(JSON.parse(expected.to_json))
expect(actual[:data]).to be_a(JSONAPI::Renderer::CachedResourcesProcessor::JSONString)
# expect(actual[:data]).to be_a(JSONAPI::Renderer::CachedResourcesProcessor::JSONString)
end
end