Fix JSON fragments caching. #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@beauby looks good. Any plans on merging this into master? |
|
@beauby looks like you merged the jsonapi-renderer PR. Any chance of merging this too? We're currently relying it, would be awesome to see it getting merged into master. We love the gem btw. You've built something really impressive. Do you have any planned features or anything that I can help with? |
|
Thanks @JoeWoodward – I have to admit I lost track of what was left to enable fragment caching. As you have used it, did you notice anything missing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies on jsonapi-rb/jsonapi-renderer#29.