Mark Storage.url overrides as keyword-only arguments
#1534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was already implicitly encouraged by the documentation and API structure, but this change ensures that callers will always pass arguments correctly. Since all additional arguments to `.url` are non-standard (compared to Django `Storage`) and vary across Django-Storages subclasses, calling with positional arguments should be disallowed. This is technically a breaking change for anyone using positional arguments, though the fix should be obvious.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was already implicitly encouraged by the documentation and API structure, but this change ensures that callers will always pass arguments correctly. Since all additional arguments to
.urlare non-standard (compared to DjangoStorage) and vary across Django-Storages subclasses, calling with positional arguments should be disallowed.This is technically a breaking change for anyone using positional arguments, though the fix should be obvious.