Allow non-GET Params to be passed to S3Storage.url
#1533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if any extra `Params` were passed to
`S3Storage.url` beyond what Boto3's `get_object` API supported,
the `generate_presigned_url` would fail. This means that a call
like:
`S3Storage.url(..., http_method='PUT`, parameters={'Tagging': ...})`
would fail, as `get_object` doesn't support `Tagging`, but `put_object` does.
brianhelba
force-pushed
the
s3-url-http-method
branch
from
8d2e442 to
b1e84e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if any extra
Paramswere passed toS3Storage.urlbeyond what Boto3'sget_objectAPI supported, thegenerate_presigned_urlwould fail. This means that a call like:would fail, as
get_objectdoesn't supportTagging, butput_objectdoes.