Introduce S3SeekableFile as a S3 file wrapper #1523
+166
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, whenever an S3 file was opened, it was directly downloaded into a `SpooledTemporaryFile`, independently if it was ever read or not. For files with a bigger size it reduced performance and increased traffic and expenses in cloud environments. This commit wraps the access to the S3 file into a S3SeekableFile wrapper which reads requested bytes on demand, without loading the file completely into memory or local storage.
| self._file, ExtraArgs=params, Config=self._storage.transfer_config | ||
| ) | ||
| self._file.seek(0) | ||
| self._file = S3SeekableFile(self.obj, ExtraArgs=params) |
There was a problem hiding this comment.
Please note that Config=self._storage.transfer_config was removed... I'm not sure if this is needed as the method changed from download_fileobj to get as well.
|
@jschneier May I bump this PR? I would love to hear from you what you think about this change. It would help a lot when working with large files on S3 if only a subset of data needs to be read. It also reduces the time it takes from opening the file until the first chunk can be processed by the application as it does not need to wait until the full download has been completed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, whenever an S3 file was opened, it was directly downloaded into a
SpooledTemporaryFile, independently if it was ever read or not. For files with a bigger size it reduced performance and increased traffic and expenses in cloud environments.This commit wraps the access to the S3 file into a S3SeekableFile wrapper which reads requested bytes on demand, without loading the file completely into memory or local storage.