Add Pages and ISBN attributes to Book entity #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatschi
reviewed
Aug 13, 2025
| @@ -123,3 +148,11 @@ annotate AdminService.Books with { | |||
| annotate AdminService.Books with { | |||
| genre @Common.ValueListWithFixedValues; | |||
| } | |||
|
|
|||
| // hint: this was needed to make the path not found at 'reviews/@UI.LineItem' go away | |||
| annotate AdminService.Reviews with @(UI: { | |||
fatschi
reviewed
Aug 13, 2025
| on reviews.book = $self; | ||
|
|
||
| pages : Integer @assert.range: [(0),_]; // hint: adds validation, must be > 0 | ||
| isbn : String(20) @assert.format: '^(?=(?:\D*\d){10}(?:(?:\D*\d){3})?$)[\d-]+$'; // hint: https://stackoverflow.com/questions/41271613/use-regex-to-verify-an-isbn-number |
There was a problem hiding this comment.
nice, does this work when you try to edit an isbn in the books-admin? does it lead to errors?
There was a problem hiding this comment.
If you input an invalid ISBN value it prevents you from saving changes to the entity. I have not tested it more extensively as in what happens when wrong data is seeded and such.
fatschi
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I have added Pages and ISBN attributes to Book entity. In addition I have resolved the issue with the
Path does not exist.CDS (annotations)error in VS Code that sprung up once the Reviews were added.