feat: add subsequent & fuzzy search #206
Open
+78
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrpie
reviewed
Jun 25, 2025
Respect the fuzzy search preference again to stop computing the fuzzy results when it is not enabled
If multiple items contain the search string perfectly the fuzzy search still expand it with suggestions. These fuzzy-suggestions, however, might have **less** occurrences in the search string than the items that contained it. The changes ensure that fuzzy-suggestions must have at least the same amount of occurrences as apps that contain the search string. Also, I removed the `appsSecondary` wrapper-list and directly work on `r`.
jrpie
reviewed
Jun 27, 2025
| val r: MutableSet<AbstractDetailedAppInfo> = hashSetOf() | ||
| val normalizedQuery: String = normalize(query) | ||
| val subsequentResult: MutableList<AbstractDetailedAppInfo> = mutableListOf(); | ||
| val occurrences: MutableMap<AbstractDetailedAppInfo, Int> = mutableMapOf(); |
There was a problem hiding this comment.
I think the approach of having multiple lists breaks down at this point. The approach with two list was mainly used to avoid sorting, but I think the code is getting very hard to read now.
I'd suggest calculating a score for each app, remove all where the score is too high, then sort them by score (and secondarily by name).
jrpie
reviewed
Jun 27, 2025
Changed the algorithm for occurrence counting to improve performance. Previously it was based on expensive string manipulations and checks. The new approach is based on a frequency map with fewer iterations.
jrpie
force-pushed
the
master
branch
2 times, most recently
from
a3e0165 to
2e95387
Compare
|
Would greatly appreciate this feature. Any way I can help move it along ? |
jrpie
force-pushed
the
master
branch
2 times, most recently
from
dc3bebb to
2cda589
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements an extended and more forgiving search mentioned in #204.