bcbs updates #154

push2stack · 2025-09-24T14:38:55Z

No description provided.

release/20250905

Update LICENSE

Bump version

commit bc517d2 Author: Kalpesh Palav <[email protected]> Date: Thu Sep 18 18:13:11 2025 +0100 lint warning fixes commit 5573158 Author: Kalpesh Palav <[email protected]> Date: Thu Sep 18 18:05:43 2025 +0100 empty resource fix commit bcb45c1 Author: Kalpesh Palav <[email protected]> Date: Thu Sep 18 17:32:31 2025 +0100 Pagination logic implementation commit 1feb08a Author: Kalpesh Palav <[email protected]> Date: Thu Sep 18 16:49:25 2025 +0100 lint warning fix commit b75b5a6 Author: Kalpesh Palav <[email protected]> Date: Thu Sep 18 16:38:57 2025 +0100 tdqm dependecy commit 05ebbe3 Author: Kalpesh Palav <[email protected]> Date: Thu Sep 18 16:35:37 2025 +0100 tqdm dependency added in pyproject commit 6ce2fab Author: Kalpesh Palav <[email protected]> Date: Thu Sep 18 15:50:32 2025 +0100 fix progress bar issue with tdqm

commit 7f2853f Author: Kalpesh Palav <[email protected]> Date: Wed Sep 17 16:50:14 2025 +0100 fix to remove extra whitespace from output commit d009ef3 Author: Kalpesh Palav <[email protected]> Date: Wed Sep 17 14:51:58 2025 +0100 fix cat and _cat functions

This reverts commit f9c8755.

This reverts commit 437a209.

Squashed commit of the following: commit c8be4f7 Author: Kalpesh Palav <[email protected]> Date: Thu Sep 18 15:50:32 2025 +0100 Pagination logic and download progress bar issue fix fix progress bar issue with tdqm tqdm dependency added in pyproject lint warning fix Pagination logic implementation empty resource fix lint warning fixes PR review changes lint warning fix for types lint fixes version update to 3.0.2-dev0

Fix cat/_cat functions | pagination logic support | download progress bar issue

Ramadevie · 2025-09-30T08:35:27Z

py_src/fusion/dataflow.py

-    # Required at create-time (optional at init-time for handles)
-    providerNode: dict[str, str] | None = None
-    consumerNode: dict[str, str] | None = None
+    # --- revert fix 1: camelCase field names restored ---


please change this comment

Ramadevie · 2025-09-30T08:58:19Z

py_src/fusion/report.py

+        client: Fusion | None = None,
+        return_resp_obj: bool = False,
+    ) -> requests.Response | None:
+        """Update this report using HTTP PUT with the current object state.


please remove HTTP PUT in the docstring

Ramadevie · 2025-09-30T08:58:38Z

py_src/fusion/report.py

+        client: Fusion | None = None,
+        return_resp_obj: bool = False,
+    ) -> requests.Response | None:
+        """Partially update this report using HTTP PATCH.


remove http patch

Ramadevie · 2025-09-30T08:59:01Z

py_src/fusion/report.py

+                payload["regulatoryRelated"] = v
+                continue
+
+            # flat "publisher_node_identifier" -> nested publisherNode.publisherNodeIdentifier


remove the commented line

Ramadevie · 2025-09-30T09:18:13Z

py_tests/test_dataflow.py

            {
-                "providerNode": {"name": "CRM_DB", "nodeType": "Database"},
-                "consumerNode": {"name": "DWH", "nodeType": "Database"},
+                "providerNode": {"name": "CRM_DB", "type": "Database"},     # was nodeType


please remove was Nodetype comment

Ramadevie · 2025-09-30T14:14:30Z

py_src/fusion/dataflow.py

-    providerNode: dict[str, str] | None = None
-    consumerNode: dict[str, str] | None = None
+    # --- camelCase field names (kept as-is) ---
+    providerNode: dict[str, Any] | None = None


Change it back to dict[str,str] for both providerNode and consumerNode to follow API

Ramadevie · 2025-09-30T14:14:52Z

py_src/fusion/dataflow.py


    Attributes:
-        providerNode (dict[str, str] | None):
+        providerNode (dict[str, Any] | None):


Change comments also to dict[str,str]

Ramadevie · 2025-09-30T14:17:06Z

py_src/fusion/dataflow.py

            Server-assigned unique identifier of the data flow. Must be set on the object for
            ``update()``, ``update_fields()``, and ``delete()``. Defaults to ``None``.

        alternativeId (dict[str, Any] | None, optional):


remove this field as it does not exist on API

Ramadevie · 2025-09-30T14:19:21Z

py_src/fusion/dataflow.py


-        boundarySets (list[dict[str, Any]], optional):
-            Boundary set objects for the data flow; items are stored as provided. Defaults to empty list.
+        datasets (list[dict[str, Any]], optional):


remove data assets from description

Ramadevie · 2025-09-30T14:20:55Z

py_src/fusion/dataflow.py

    def from_dict(cls: type[Dataflow], data: dict[str, Any]) -> Dataflow:
        """Create a Dataflow object from a dictionary.

        Accepts camelCase or snake_case keys and normalizes empty strings to None.


add back Args and Returns in docstring

Ramadevie · 2025-09-30T14:23:18Z

py_src/fusion/dataflow.py

-        forbidden = {"provider_node", "consumer_node"}
-        normalized = {camel_to_snake(k): v for k, v in changes.items()}
-        used = forbidden.intersection(normalized.keys())
+        # forbid changing nodes via PATCH


remove this commented line

Ramadevie · 2025-09-30T14:25:37Z

py_src/fusion/dataflow.py

            )

-        patch_body = {snake_to_camel(k): v for k, v in normalized.items()}
+        # normalize empty strings to None recursively, keep keys camelCase


duplicate code

Ramadevie · 2025-09-30T14:26:05Z

py_src/fusion/dataflow.py


-        patch_body = {snake_to_camel(k): v for k, v in normalized.items()}
+        # normalize empty strings to None recursively, keep keys camelCase
+        def normalize_value(val: Any) -> Any:


call these in post_init()

Ramadevie · 2025-09-30T14:33:51Z

py_src/fusion/fusion.py

-                - mnpi_indicator (bool)
-                - country_of_reporting_obligation (str)
-                - primary_regulator (str)
+            description (str | None): Description of the report.


Update the docstring for those required fields

Ramadevie · 2025-09-30T14:35:05Z

py_src/fusion/fusion.py

+        provider_node: dict[str, str] | None = None,
+        consumer_node: dict[str, str] | None = None,
+        description: str | None = None,
+        alternative_id: dict[str, Any] | None = None,


this should be removed as no longer exist in API

lint fixes Unit tests and lint fixes changed elements to attributes refactoring and lint fixes Version update to 3.0.3-dev0 removing id from def create payload added 'id' in fusion report_attribute lint errors fix removing title from def update unit test fix extra check validation removed fix return dataframe in test_list_report_KDEs test fix payload fix title parameter changed to optional lint fixes fix payload for update_fields lint warning fixes version revert, removed KDE method fix get dataset from_catalog function for catalogs with no products lint warning fix fix exception message, align with pyfusion 3.7 tags issue solved test fix Report attribute arguments camel case fix to snake case

Ramadevie · 2025-10-02T16:27:54Z

py_src/fusion/dataflow.py

            )

-        patch_body = {snake_to_camel(k): v for k, v in normalized.items()}
+        def clean(v: Any) -> Any:


Do we need to do this? it should be done on post_init()

Ramadevie · 2025-10-02T16:29:22Z

py_src/fusion/dataflow.py

        return_resp_obj: bool = False,
    ) -> requests.Response | None:
-        """Partial update (PATCH) using self.id. Provider/consumer nodes are not allowed."""
+        """Partial update using id.


remove changes parameter, use fields from Dataflow

Ramadevie · 2025-10-02T16:38:17Z

py_src/fusion/report.py


        def convert_keys(d: dict[str, Any]) -> dict[str, Any]:
-            converted = {}
+            converted: dict[str, Any] = {}


we dont need this, it should be directly converted from camel to snake, then modify the dict just replace isBCBS239Program

Ramadevie · 2025-10-02T16:47:32Z

py_src/fusion/report.py

+            ... )
+            >>> payload = report.to_dict()
        """
+        def _camelize(obj: Any) -> Any:


change the parameter name to have BCBS as upper case, and ignore it for conversion, then all this logic is not necessary, directly snake_to_camel function canb e used

Or use sanke_to_camel and replace this parameter in response dict.

Ramadevie · 2025-10-02T16:49:57Z

py_src/fusion/report.py

+        client = self._use_client(client)
+        payload = self.to_dict()
+
+        def _strip_ids(x: Any) -> Any:


can this be moved to post_init()?

Ramadevie · 2025-10-02T16:51:53Z

py_src/fusion/report.py

+
+    def update_fields(
+        self,
+        fields_to_update: dict[str, Any],


remove this, and use the object to update

Ramadevie · 2025-10-02T16:53:43Z

py_src/fusion/report.py

-        resp: requests.Response = client.session.post(url, json=data)
+        payload: dict[str, Any] = {}
+        for k, v in fields_to_update.items():
+            sk = camel_to_snake(k)


use to_dict()

Ramadevie and others added 10 commits September 5, 2025 20:55

Merge pull request #148 from jpmorganchase/release/20250905

3b17462

release/20250905

Merge pull request #149 from jpmorganchase/release/20250905

3f0e114

Update LICENSE

Merge pull request #150 from jpmorganchase/release/20250905

b1430db

Bump version

Revert "Squashed commit of the following:"

9358258

This reverts commit f9c8755.

Revert "Squashed commit of the following:"

e6cad77

This reverts commit 437a209.

Add SDK version to user agent header and Update publishing token (#153)

baca812

Merge pull request #152 from jpmorganchase/Fix-cat-and-_cat-functions

70c1529

Fix cat/_cat functions | pagination logic support | download progress bar issue

Ramadevie requested changes Sep 30, 2025

View reviewed changes

Kalpesh-Palav and others added 2 commits October 2, 2025 11:28

BCBS Updates - Reports and Dataflows

80cfb3b

push2stack force-pushed the feature/bcbs-updates1 branch from fa8af4e to 80cfb3b Compare October 2, 2025 15:47

push2stack changed the base branch from master to release/20250905 October 2, 2025 15:48

Ramadevie requested changes Oct 2, 2025

View reviewed changes

addressed comemnts

a9eb543

bcbs updates #154

Are you sure you want to change the base?

bcbs updates #154

Uh oh!

Conversation

push2stack commented Sep 24, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!