Support talking to legacy JSON-RPC 1.0 servers #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should support any types of error responses, including:
- `{..., "error": {"code": -42, "message": "spam"}}`,
- `{..., "error": {"reason": "spam"}}`,
- `{..., "error": {"what_happened": "spam"}}`,
- or even `{..., "error": "spam"}}`
|
Is the author dead? No comments for 4 months? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've needed to talk to legacy JSON-RPC 1.0 server and found that there's no library on PyPi that could readily do it.
KeyErrorexception (see issue 1.0 Specification error field #13);paramsare mandatory, even if empty (see this commit in alanbriolat/jsonrpclib fork).Here are quick fixes, which I hope could be merged. Error handling modifications should not affect working with any compliant 1.1+ server, but only more eagerly accept possible 1.0 oddities.
Thanks.