Use attributes instead of annotations for PHPUnit 12 #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is supported from PHPUnit 10 so no issue with the current project state.
joshhanley
approved these changes
Jun 2, 2025
There was a problem hiding this comment.
@shulard thanks for the PR! Not sure why you added the extra driver method. To me it seems like all we need is to change the test attribute. So I've removed it for now. In future please either put things like that in a separate PR or explain why it's needed. Thanks!
Yes you were completely right, sorry for pushing a wrong change here ^^ |
|
@shulard ah right, no worries! Thanks again 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is supported from PHPUnit 10 so no issue with the current project state.
Thank you @adry84 for the details 😉.