fix: #3421 require a space or delimiter after hex, bin, and oct values #3463
+24
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3421
A simple solution is to not only parse hex characters, but just parse any alpha and digit character after the prefix
0x
,0o
, or0x
, and then try to parse the string into a number. When evaluating0x1k
, this will give an error messate "SyntaxError: String "0x1k" is not a valid number".An alternative solution would be to create separate flows for parsing
hex
,oct
, andbin
, with specific functionsisHexDigit
,isOctDigit
andisBinDigit
, and then we need a separate check to see if the value is followed by an alpha or digit character and then throw an error like "Unexpected character 'k' (char: 3)". I think though that the former is a more informative error message.@gwhitney can you have a brief look at this PR?