Moving media generation to base class instead of separate class #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HLeithner
reviewed
Apr 17, 2025
| ->run(); | ||
|
|
||
| $this->addFiles('media', $media->getResultFiles()); | ||
| $this->buildMediaFiles('tpl_' . $this->templateName); |
Member
There was a problem hiding this comment.
Suggested change
| $this->buildMediaFiles('tpl_' . $this->templateName); | |
| $this->buildMediaFiles($this->templateName); |
templates don't use the tpl_ prefix
Collaborator
Author
There was a problem hiding this comment.
I'm just handing in the name of the extension and the prefix lets the system discover which type it is. In this case, the tpl_ is necessary.
Member
|
you removed the media folder for file but not the language? ok I looked at the |
Collaborator
Author
|
Yes, the File type currently is fubar, but that shouldn't stop this PR. 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the copying of media files into the build folder from the Media class into the base class. This should make the code just simpler and less over-engineered. Right now the file extension type does not feel correct.