Adding CHECKSUM files when building an extension #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HLeithner
reviewed
Apr 17, 2025
| $output[] = $checksum . ' ' . $path; | ||
| } | ||
|
|
||
| return (bool) file_put_contents($target . '/CHECKSUM', implode("\n", $output)); |
Member
There was a problem hiding this comment.
does this need to be uppercase?
cms uses 'checksums.txt'
Collaborator
Author
There was a problem hiding this comment.
No, it doesn't have to be. I did a few google searches before implementing this and the suggestion was to use the uppercase version and to add the hash type as file extension. But either way, I'm not married to the filename. Just to create a standard now which the CMS can then adopt in a later version.
Member
There was a problem hiding this comment.
For me I don't care if it has an file extension as linux user, but other operating systems have some issues to open it in an editor without file extension. just saying
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds CHECKSUM files for each extension. These files contain a list of all files of the respective extension and their respective sha256 hash. This should eventually allow Joomla to check the integrity of all files, once this has been added to the CMS. 😉
The language files in the global language folders are currently not added to the CHECKSUM file yet.