Add blur intensity #15
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it possible to review this PR please ? |
mikhailmaslo
reviewed
Mar 9, 2023
There was a problem hiding this comment.
CustomIntensityVisualEffectView looks hacky, also intensity is not a part of standard UIVisualEffectView
So, I suggest to provide a way to customize BottomSheet views through, for example, delegate. In this way, you can provide your own view (CustomIntensityVisualEffectView)
In this delegate method can be a method:
func makeShadowView(
presentationViewController: UIPresentationViewController,
configuration: BottomSheetConfiguration
) -> UIViewThen, this method is used by presentation controller to make a shadow. If nothing is provided, default implementation (current) will be used
What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a parameter in config to manage blur intensity