Linux support #314
Draft
Linux support #314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this uses the native (nativest) option on linux: ffmpeg. Because LGPL may be an issue, this adds support using calls to the ffmpeg binary, which is expected to be present on the user's system, instead of linking to libav. Encoding uses libx264 and ffmpeg's built-in AAC encoder for maximum compatibility with user installs. The code is written in C++ instead of Dart because i figured this way the main codebase stays untouched, and linux-specific code stays out of the way of the rest. Most of the code in `./linux` and `./example/linux` has been generated by flutter and left untouched. The only files written by hand are `./linux/video_compress_plugin.cc` and `./linux/video_compress_plugin_private.h`. I've also added a CMake directive in `./linux/CMakeLists.txt` to export a `compile_commands.json` file for development with clangd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I would like to use your library in a IRC client i'm helping build. The client targets android, ios and linux, and we do most of the testing on linux, so it'd be much appreciated if this worked in some way on the platform. :D
this uses the native (nativest) option on linux: ffmpeg.
Because LGPL may be an issue, this adds support using calls to the ffmpeg binary, which is expected to be present on the user's system, instead of linking to libav.
Encoding uses libx264 and ffmpeg's built-in AAC encoder for maximum compatibility with user installs.
The code is written in C++ instead of Dart because i figured this way the main codebase stays untouched, and linux-specific code stays out of the way of the rest.
Most of the code in
./linuxand./example/linuxhas been generated by flutter and left untouched. The only files written by hand are./linux/video_compress_plugin.ccand./linux/video_compress_plugin_private.h. I've also added a CMake directive in./linux/CMakeLists.txtto export acompile_commands.jsonfile for development with clangd.TODO
See #253