Skip to content

make get file thumbnail safe #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

make get file thumbnail safe #303

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 15 additions & 10 deletions lib/src/video_compress/video_compressor.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,10 @@ extension Compress on IVideoCompress {
Future<T?> _invoke<T>(String name, [Map<String, dynamic>? params]) async {
T? result;
try {
result = params != null
? await channel.invokeMethod(name, params)
: await channel.invokeMethod(name);
result =
params != null
? await channel.invokeMethod(name, params)
: await channel.invokeMethod(name);
} on PlatformException catch (e) {
debugPrint('''Error from VideoCompress:
Method: $name
Expand Down Expand Up @@ -68,7 +69,7 @@ extension Compress on IVideoCompress {
/// getFileThumbnail return [Future<File>]
/// quality can be controlled by [quality] from 1 to 100,
/// select the position unit in the video by [position] is milliseconds
Future<File> getFileThumbnail(
Future<File?> getFileThumbnail(
String path, {
int quality = 100,
int position = -1,
Expand All @@ -83,7 +84,11 @@ extension Compress on IVideoCompress {
'position': position,
}));

final file = File(Uri.decodeFull(filePath!));
if (filePath == null) {
return null;
}

final file = File(Uri.decodeFull(filePath));

return file;
}
Expand Down Expand Up @@ -130,9 +135,11 @@ extension Compress on IVideoCompress {
int frameRate = 30,
}) async {
if (isCompressing) {
throw StateError('''VideoCompress Error:
throw StateError(
'''VideoCompress Error:
Method: compressVideo
Already have a compression process, you need to wait for the process to finish or stop it''');
Already have a compression process, you need to wait for the process to finish or stop it''',
);
}

if (compressProgress$.notSubscribed) {
Expand Down Expand Up @@ -176,8 +183,6 @@ extension Compress on IVideoCompress {
}

Future<void> setLogLevel(int logLevel) async {
return await _invoke<void>('setLogLevel', {
'logLevel': logLevel,
});
return await _invoke<void>('setLogLevel', {'logLevel': logLevel});
}
}