Skip to content

fixed bad access in a debug message #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tamoyal
Copy link

@tamoyal tamoyal commented Jan 9, 2015

Issue #26

@johnewart
Copy link
Owner

The client spec test fails with this -- https://github.com/johnewart/gearman-ruby/blob/master/spec/client_spec.rb#L57 needs to be updated to stub to_host_port or (probably better, but more work) be modeled to only stub the connectivity bits. Mind updating that and making sure specs pass?

@tamoyal
Copy link
Author

tamoyal commented Jan 13, 2015

Makes sense. I fixed and it looks like everything passes now but I get these warnings / deprecations:

Pending:
  Gearman::TaskSet handles a NetworkError when submitting a job
    # Temporarily skipped with xit
    # ./spec/taskset_spec.rb:16
  Gearman::TaskSet waits for an answer from the server
    # Temporarily skipped with xit
    # ./spec/taskset_spec.rb:44

Deprecation Warnings:

Using `should_not` from rspec-expectations' old `:should` syntax without explicitly enabling the syntax is deprecated. Use the new `:expect` syntax or explicitly enable `:should` instead. Called from /Users/tamoyal/Projects/Sidewalk/gearman-ruby/spec/client_spec.rb:21:in `block (2 levels) in <top (required)>'.

Using `stub` from rspec-mocks' old `:should` syntax without explicitly enabling the syntax is deprecated. Use the new `:expect` syntax or explicitly enable `:should` instead. Called from /Users/tamoyal/Projects/Sidewalk/gearman-ruby/spec/client_spec.rb:15:in `block (2 levels) in <top (required)>'.

are those to be expected?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants