Skip to content

fix proxy.ts #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix proxy.ts #267

wants to merge 1 commit into from

Conversation

cooye
Copy link

@cooye cooye commented Oct 5, 2022

ERR_HTTP_TRAILER_INVALID

@cooye
fix proxy.ts
289236c 
ERR_HTTP_TRAILER_INVALID
itsmrshow
itsmrshow reviewed Oct 19, 2022
View reviewed changes
Copy link

@itsmrshow itsmrshow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested these changes, it stops the WebSocket from breaking on a failed header overwrite.

@Cerusa
Copy link

Cerusa commented Nov 6, 2022

This commit just makes sense. Otherwise the request just stops all activity.

@joeferner
Copy link
Owner

@itsmrshow any thoughts on why this might be happening and how to reproduce?

@Apollon77
Copy link
Contributor

@itsmrshow @cooye Is there any full stack trace or such for this? I agree that it might be better to understand the issues instead using a "meta try-catch" to catch anything

@sweet-peach sweet-peach mentioned this pull request Mar 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@itsmrshow itsmrshow itsmrshow left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cooye @Cerusa @joeferner @Apollon77 @itsmrshow