add new button for {attachments id=xxx } #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Good job @JLTRY! It needs a couple of fixes but seems to work well combined with the other pull request. I'll add the changes in the review as I don't want to mix the two pull requests and push anything wrong to your branch. |
parapente
reviewed
Nov 23, 2024
insert_attachments_id_token_btn_plugin/insert_attachments_id_token.xml
Outdated
Show resolved
Hide resolved
insert_attachments_id_token_btn_plugin/src/Extension/InsertAttachmentsIdToken.php
Outdated
Show resolved
Hide resolved
insert_attachments_id_token_btn_plugin/src/Extension/InsertAttachmentsIdToken.php
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
Hello fill free to modify if you have time I am in vacation.I made a dedicated branch for this pr |
…ton when showing the add attachment ids dialog
Collaborator
Collaborator
Author
|
@parapente merged. Let me know which version we should set for next release |
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added filter to add only attachments from current article