Skip to content

Conversation

@JLTRY
Copy link
Collaborator

@JLTRY JLTRY commented Jan 6, 2025

Left icon is for viewing attahcment . Right one is for download (if secure download options is set)

@parapente
Copy link
Collaborator

@JLTRY testing this patch I noticed that if you don't select to open the file in a modal the file url is exposed to the user. Secure download and modal should work as is (you just have to select from the attachments options -> Security to download the file inline).

If what you want to achieve is to have the file both show in a modal and have an icon to download then you should keep the url as is and just show the extra icon whenever the option to open the attachment in a modal is enabled. It would be nice to be configurable too.

@JLTRY JLTRY changed the title Add download link to be able to view attachement ina poprup or downlo… Add download link to be able to view attachement in a popup or downlo… Jan 6, 2025
=> show icon if option selected and mode is popup
@JLTRY
Copy link
Collaborator Author

JLTRY commented Jan 6, 2025

@parapente I rewrote feature
It will show only in popup mode + if option is selected

Copy link
Collaborator

@parapente parapente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't merge this yet. I need to push a couple of changes. Looks good now.

@parapente
Copy link
Collaborator

@JLTRY see the suggestions above and the changes I made and if you agree merge the PR.

@JLTRY JLTRY merged commit 942c157 into jmcameron:master Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants