Skip to content

Conversation

@vivster7
Copy link

@vivster7 vivster7 commented Mar 16, 2025

Adds a 🎯 button to the ctrl+f search bar that toggles an 'exact match' filter mode -- it only shows frames that exactly match the search query.

Personal.perf-vertx-stacks-01-collapsed-all.txt.-.speedscope.-.16.March.2025.mp4

This is one possible implementation for #192

The use case I was trying to support: simplify large call graphs into first party code vs specific third party libraries. Seems related to the following issues as well

Filtering the profile on keystroke feels like a fairly expensive operation, but I wasn't sure how else to implement. My fork solves my use case, but would be nice to upstream this feature if you'd accept this patch or a similar variant.

@jack-mcivor
Copy link

@vivster7 does this implement searching by filename #468 ?

I think that for my profile (Python code, generated with Autin) filtering by filename is the only way to achieve a distinction between first party code & specific third party libraries

@vivster7
Copy link
Author

@jack-mcivor I think so -- it matches against the frame's name, so if your frame contains the filename, you should be able to filter the "time order" and "left heavy" views by filename. I don't think this will do anything to the sandwich view though (which is maybe specifically what #468 was asking)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants