Bugfix: evaluate pixel height as integers to avoid browser-specific s… #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ubpixel calculation differences. See projectblacklight/arclight#1027 for examples where Firefox would evaluate truncate.height() as 61.2, truncate_height as 61.1999... and thus not expand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ubpixel calculation differences.
See projectblacklight/arclight#1027 for examples where Firefox would evaluate
truncate.height() as 61.2, truncate_height as 61.1999... and thus not expand.
Also noting that the original
==comparison operator in the line in question was changed to<=in ArcLight in this Oct 3, 2019 commit:projectblacklight/arclight@406379f