Skip to content

Add Build variables #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Build variables #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions go_modules
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ def extract(filename, outdir):
os.chdir(cwd)


def cmd_go_mod(cmd, moddir):
def cmd_go_mod(cmd, moddir, env):
"""Execute go mod subcommand using subprocess.run().
Capture both stderr and stdout as text.
Log as info or error in this function body.
Expand All @@ -191,9 +191,9 @@ def cmd_go_mod(cmd, moddir):
log.info(f"go mod {cmd}")
# subprocess.run() returns CompletedProcess cp
if sys.version_info >= (3, 7):
cp = run(["go", "mod", cmd], cwd=moddir, capture_output=True, text=True)
cp = run(["go", "mod", cmd], cwd=moddir, capture_output=True, text=True, env=env)
else:
cp = run(["go", "mod", cmd], cwd=moddir)
cp = run(["go", "mod", cmd], cwd=moddir, env=env)
if cp.returncode:
log.error(cp.stderr.strip())
return cp
Expand All @@ -220,6 +220,10 @@ def main():
parser.add_argument("--basename")
parser.add_argument("--vendorname", default=DEFAULT_VENDOR_STEM)
parser.add_argument("--subdir")
parser.add_argument("--GOPRIVATE", default=None)
parser.add_argument("--GODEBUG", default="x509ignoreCN=0")
parser.add_argument("--GOCACHE", default="/tmp/GOCACHE")
parser.add_argument("--GOPATH", default="/tmp/GOPATH")
args = parser.parse_args()

outdir = args.outdir
Expand Down Expand Up @@ -268,9 +272,16 @@ def main():
# (also downloads but use separate steps for visibility in OBS environment)
# - go mod verify
# (validates checksums)

env=os.environ
if args.GOPRIVATE is not None:
env["GOPRIVATE"]=args.GOPRIVATE
env["GODEBUG"]=args.GODEBUG
env["GOCACHE"]=args.GOCACHE
env["GOPATH"]=args.GOPATH

# return value cp is type subprocess.CompletedProcess
cp = cmd_go_mod("download", go_mod_dir)
cp = cmd_go_mod("download", go_mod_dir, env)
if cp.returncode:
if "invalid version" in cp.stderr:
log.warning(
Expand All @@ -283,12 +294,12 @@ def main():
log.error("go mod download failed")
exit(1)

cp = cmd_go_mod("vendor", go_mod_dir)
cp = cmd_go_mod("vendor", go_mod_dir, env)
if cp.returncode:
log.error("go mod vendor failed")
exit(1)

cp = cmd_go_mod("verify", go_mod_dir)
cp = cmd_go_mod("verify", go_mod_dir, env)
if cp.returncode:
log.error("go mod verify failed")
exit(1)
Expand Down
12 changes: 12 additions & 0 deletions go_modules.service
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,16 @@
<parameter name="vendorname">
<description>Specify the name for the generated vendor tarball. Default: vendor</description>
</parameter>
<parameter name="GOPRIVATE">
<description>Comma-separated list of glob patterns</description>
</parameter>
<parameter name="GODEBUG">
<description>Enable various debugging facilities. default="x509ignoreCN=0"</description>
</parameter>
<parameter name="GOCACHE">
<description>The directory where the go command will store cached information for reuse in future builds. default="/tmp/GOCACHE"</description>
</parameter>
<parameter name="GOPATH">
<description>The Go path is used to resolve import statements. default="/tmp/GOPATH"</description>
</parameter>
</service>