Fix points rendering for Chrome on Mac. #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This vertex attribute was used without being enabled. On almost every platform, it so happened that the attributes here were being assigned integer values that made the app work correctly. However, this vertex attribute was actually relying on a vertex attrbute enabled for one of the other draw calls. In Chrome on Mac, the vertex attributes for the picking shader are 2,0,1 (or something like that), while they are 2,1,0 on Firefox. This seems like it's probably a property of the GL driver; maybe Firefox works around it.
|
This definitely fixed Chrome/Mac for me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This vertex attribute was used without being enabled.
On almost every platform, it so happened that the attributes here were
being assigned integer values that made the app work correctly. However,
this vertex attribute was actually relying on a vertex attrbute enabled
for one of the other draw calls. In Chrome on Mac, the vertex attributes for
the picking shader are 2,0,1 (or something like that), while they are
2,1,0 on Firefox. This seems like it's probably a property of the GL
driver; maybe Firefox works around it.