Skip to content

Conversation

anhcraft
Copy link

@anhcraft anhcraft commented Mar 9, 2024

I noticed that PluginManager#findPluginsToDownload has a wrong logic if-else. For a requested plugin, if there is both installed plugin and bundled plugin, then the method only gets the version from the installed one without checking if the bundled one is newer. The else logic was added in c445dea

Testing done

I have adjusted the test case to suit the new changes.

Submitter checklist

- [x] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [x] Ensure that the pull request title represents the desired changelog entry
- [x] Please describe what you did
- [ ] Link to relevant issues in GitHub or Jira
- [ ] Link to relevant pull requests, esp. upstream and downstream changes
- [x] Ensure you have provided tests - that demonstrates feature works or fixes the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant