Add LlvmLinkerParser for LLVM lld linker error parsing #1245
Conversation
- Add LlvmLinkerParser class for parsing ld.lld error messages - Support versioned linkers (ld.lld-15, etc.) - Handle error/warning/note severity levels - Integrate with ClangDescriptor using composite pattern - Add comprehensive unit and integration tests Resolves JENKINS-76141
| private static final long serialVersionUID = 1L; | ||
|
|
||
| // Pattern that captures the linker name specifically | ||
| private static final String LLD_LINKER_PATTERN = "^.*[/\\\\]?(ld\\.lld(?:-\\d+)?):\\s*(error|warning|note):\\s*(.*)$"; |
There was a problem hiding this comment.
Can you please use names for capturing groups? This would make the pattern more readable for future changes: https://jdriven.com/blog/2020/04/Java-Joy-Using-Named-Capturing-Groups-In-Regular-Expressions
| .buildOptional(); | ||
| } | ||
|
|
||
| private Severity mapPriority(final String severity) { |
There was a problem hiding this comment.
We have an automatic mapping in Severity#guessSeverity (it maps errors to Severity.ERROR though). But if you want to map errors to severity HIGH then your code is just fine.
| /** | ||
| * A parser for LLVM lld linker warnings and errors. | ||
| * | ||
| * @author [Your Name] |
There was a problem hiding this comment.
Either your name or remove the lines:
| * @author [Your Name] | |
| * @author Steven Scheffler |
| /** | ||
| * Tests the class {@link LlvmLinkerParser}. | ||
| * | ||
| * @author [Your Name] |
There was a problem hiding this comment.
| * @author [Your Name] | |
| * @author Steven Scheffler |
| assertThat(warnings.stream().allMatch(issue -> | ||
| issue.getFileName().endsWith("ld.lld"))) | ||
| .isTrue(); |
There was a problem hiding this comment.
Normally in AssertJ one would use:
assertThat(warnings.stream())
.allSatisfy(issue -> assertThat(issue).hasFileName("ld.lld"));
But this is semantically equivalent...
|
@sgscheffler ping: I'm not sure if you have enabled your notifications... |
Summary
Add LlvmLinkerParser for LLVM lld linker error parsing
Changes
Resolves JENKINS-76141
Testing Done
Unit Tests
LlvmLinkerParserTestwith 7 test methods covering:Integration Tests
shouldFindAllClangAndLldIssuesto ParsersTestManual Testing
mvn clean testpassesVerification
Submitter Checklist