-
Notifications
You must be signed in to change notification settings - Fork 87
EncryptedDirectMessage class; simplify Event
#39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
ACK Type annotations good |
Owner
jeffthibault
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kdmukai! Did a first pass and added a few comments and questions.
* Simpler Event instantiation w/content string w/out kwarg. * `tags` attr default value via factory. * `id` changed to a compute-on-the-fly property; eliminates all the redundant `compute_id()` calls. * Simpler DM instantiation (same as `Event`); simply copies the `content` field over to `cleartext_content` and no longer throws Exception. * Asking for a DM's `id` raises an Exception if its message hasn't been encrypted yet. * Adds/updates relevant Event tests. * Restores key.mine_vanity_key.
Contributor
Author
|
@jeffthibault great notes! All my updates are now committed.
|
Owner
|
Thanks @kdmukai. This looks great! Tested ACK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one probably should have been separated out into 3-4 small PRs. I can pull these apart if need be.
EncryptedDirectMessageclassDerived from the parent
Eventclass to provide a more human-friendly way to construct a DM:provides a clean way to differentiate the cleartext content from the ultimate encryptedcontent`.contentthrows an exception.PrivateKey.sign()encrypts the message for us and populates thecontentfield.PrivateKey.encrypt_dm()convenience method added while preserving the more generalencrypt_message()in case that finds other uses(?).Eventtypes and so can be passed straight on to theRelayManager.Event.__init__boilerplate removed viadataclassBoilerplate bad. DRY good.
Simplified
EventinstantiationWe're going to sign an
Eventwith ourPrivateKeyanyway so there's no need to populate theEvent.public_keyfield on instantiation.This same simplification is also demonstrated in the
EncryptedDirectMessageexample above.README examples updated accordingly.
Eventexplicit 'e' and 'p' tag supportSimilar to the discussion in #12:
add_event_ref(event_id)to generate 'e' tagsadd_pubkey_ref(pubkey)to generate 'p' tags