Adding z-index to mentio-menu and making positioning 'fixed' #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ol the z-index of the dropdown.
stefan-zh
changed the title
|
I don't think you always want the position of the menu to be fixed. I just added a PR (#177) that sets the position of the menu to fixed only if the textarea/input has a fixed ancestor. Outside of a fixed element, a fixed menu won't stick with the textarea/input as you scroll. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding mentio-z-index property to both mentio and mentio-menu to control the z-index value of the @mentions dropdown. This is a replica of pull request #99, but #99 only covers mentio-menu, so I am extending the property to mentio as well. The same issue has been tackled by pull request #82 as well.
Also changing the absolute positioning of the menu to fixed, which touches on #146. I selected 'fixed' because it relates to the point-of-view instead of 'absolute' which in this cases is absolutely positioned off of the
<body>tag since the<mentio-menu>element is always positioned inside the<body>.