Skip to content

Conversation

@msaadsbr
Copy link
Contributor

Fixes Issue

Closes #571

Description

This pull request addresses the issue where the scene list for the manim-slides convert command was unsorted.

As suggested in the issue discussion, this PR modifies the _list_scenes function in manim_slides/present/__init__.py to return an alphabetically sorted list by changing return scenes to return sorted(scenes).

Check List

Check all the applicable boxes:

  • I understand that my contributions needs to pass the checks;
  • If I created new functions / methods, I documented them and add type hints;
  • If I modified already existing code, I updated the documentation accordingly;
  • The title of my pull request is a short description of the requested changes.

Screenshots

Not applicable for this change.

Note to reviewers

This is a straightforward, one-line fix as suggested in the issue. Thanks!

@jeertmans jeertmans added enhancement New feature or request hacktoberfest-accepted PR accepted as contribution taking part to the hacktoberfest labels Oct 22, 2025
@jeertmans
Copy link
Owner

Thanks for your contribution @msaadsbr! Could you add an entry to the changelog? That would be great :)

@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.12%. Comparing base (40ed77b) to head (bc1e2d7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #573   +/-   ##
=======================================
  Coverage   80.12%   80.12%           
=======================================
  Files          23       23           
  Lines        2038     2038           
=======================================
  Hits         1633     1633           
  Misses        405      405           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@msaadsbr msaadsbr force-pushed the fix/sort-scene-list branch from 4a38106 to bc1e2d7 Compare October 23, 2025 05:52
@msaadsbr
Copy link
Contributor Author

Hey @jeertmans, I add an entry to Changelog!

@jeertmans jeertmans changed the title fix: Sort scene list alphabetically in 'convert' command feat(lib): sort scenes alphabetically when listing them Oct 23, 2025
@jeertmans
Copy link
Owner

Thank you @msaadsbr!

@jeertmans jeertmans merged commit 3034ce0 into jeertmans:main Oct 23, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request hacktoberfest-accepted PR accepted as contribution taking part to the hacktoberfest

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Sorting of Slide Scenes - would be good to sort alphabetically

2 participants