Skip to content

Conversation

Swordsman-Inaction
Copy link

The case:

render() {
  return (
    {
      this.state.visible && (
        <Popover
          isVisible={true}
          fromRect={x: 10, y: 10, width: 10, height: 10}>
            <View />
        </Popover>
      )
    }
  )
}

In this case, the Popover won't show since the props never change, and this.setState({contentSize: {}, isAwaitingShow: true}) will never be called in componentWillReceiveProps .

This PR is to fix the bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant