-
Notifications
You must be signed in to change notification settings - Fork 306
Feature/no slide looping #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
1bac41d
7c371c8
312af87
5eb8308
e276b95
7b01d2a
3d3c863
4b4837a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,6 +16,7 @@ | |
|
||
<script type="text/javascript"> | ||
{{{script}}} | ||
ALLOW_LOOPING = {{#allowLooping}}true{{/allowLooping}}{{^allowLooping}}false{{/allowLooping}}; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. could we throw a There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We could, except that its not a declaration (that's up in There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh, good catch, you're absolutely right :) Thanks for the explanation. |
||
</script> | ||
</body> | ||
</html> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was going to ask why not just use 1 for
FIRST_SLIDE
but, ack!, this method is weird. I like your solution :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, since it uses relative values, "1" means "advance one slide", so had to pick values outside any useful range. I suppose if someone ends up with a 10,000,000 slide presentation there will be problems with this feature, but it seems like that's a fair "bug" to leave latent.