Skip to content

Conversation

MonkBen
Copy link

@MonkBen MonkBen commented Sep 30, 2025

In this PR I'm updating httpsnippet to use a JCI specific version. This is needed since the previous httpsnippet restricted the node versions to a max of node 20.

@michaelgwelch
Copy link
Member

@MonkBen sorry my bad. I didn't really finish the PR on httpsnippet. When we tag the repo we should also have a matching version in package.json.

So that repo should be fixed/corrected first. Then bring in the new version. I'd delete the current tag as we'd want the tag to correspond to the version of the repo that has the correct version number in package.json

@michaelgwelch
Copy link
Member

I'm not sure what the build error is. Can you check that @MonkBen ?

@MonkBen
Copy link
Author

MonkBen commented Sep 30, 2025

@michaelgwelch, the problem is that the new httpsnippet doesn't have a dist folder: https://github.com/jci-metasys/openapi-snippet/actions/runs/18132904336/job/51603986536?pr=15#step:5:13

By default, that is ignored: https://github.com/jci-metasys/httpsnippet/blob/master/.gitignore#L4

Since we aren't publishing to npm nor a local registry, one solution is we could remove that line from .gitignore and then build httpsnippet and then commit the changes. I don't know of another solution but am open to anything...

@MonkBen MonkBen closed this Sep 30, 2025
@MonkBen MonkBen reopened this Sep 30, 2025
@MonkBen MonkBen merged commit d73f22b into jci-metasys:main Sep 30, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants