SimpleTcpClient: add AddressFamily to TcpClient #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If IPv6 address is given or resolved from hostname, TcpClient needs to be initialized with InterNetworkV6 AddressFamily, else it refuses to connect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If IPv6 address is given or resolved from hostname, TcpClient needs to be initialized with InterNetworkV6 AddressFamily, else it refuses to connect.
A very simple test to make is to use
localhostinstead of127.0.0.1. In my setup, it resolves to::1and SimpleTcpClient cannotConnect().